Hello Vijay,
On 22/02/17 09:18, Vijay Kilari wrote:
On Mon, Feb 20, 2017 at 5:09 PM, Julien Grall <julien.gr...@arm.com> wrote:
Hello Vijay,
On 09/02/17 15:56, vijay.kil...@gmail.com wrote:
From: Vijaya Kumar K <vijaya.ku...@cavium.com>
Right not CONFIG_NUMA is not enabled for ARM and
s/not/now/
existing code in asm-arm/numa.h is for !COFIG_NUMA.
s/COFIG_NUMA/CONFIG_NUMA/
Hence put this code under #ifndef CONFIG_NUMA.
This help to make this changes work when CONFIG_NUMA
is not enabled.
Is there any reason to let the choice to the user to enable/disable NUMA?
I see no reason. Atleast in case of x86, I see it is enabled always.
Stefano, do you have any opinion on whether a user should be able to
enable/disable NUMA?
Also define NODES_SHIFT macro for ARM.
Signed-off-by: Vijaya Kumar K <vijaya.ku...@cavium.com>
---
xen/include/asm-arm/numa.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/xen/include/asm-arm/numa.h b/xen/include/asm-arm/numa.h
index a2c1a34..a60c7eb 100644
--- a/xen/include/asm-arm/numa.h
+++ b/xen/include/asm-arm/numa.h
@@ -3,6 +3,9 @@
typedef u8 nodeid_t;
+#define NODES_SHIFT 2
Why 2?
Just to support upto 4 node system.
Why only 4 node supported? Also, this should be specified in the commit
message.
Regards,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
