> On 26. Jan 2018, at 11:43, Wei Liu <wei.l...@citrix.com> wrote: > > On Fri, Jan 26, 2018 at 09:29:20AM +0000, Christian Lindig wrote: >> >> >>> On 26. Jan 2018, at 09:09, M A Young <m.a.yo...@durham.ac.uk> wrote: >>> >>> On Fri, 26 Jan 2018, John Thomson wrote: >>> >>>> Use autoconf to test if ocaml version >= 4.02 >>>> If so, use -unsafe-string for ocamlopt and ocamlc >>>> >>>> Bytes & safe-string were introduced in ocaml 4.02 (2015-07-27) >>>> >>>> With ocaml 4.06, -safe-string is now default >>>> This separates the types bytes (mutable string) and string >>> >>> For Fedora Rawhide, which has ocaml 4.06, we came up with a patch to make >>> xen ocaml safe-strings compliant (which I haven't got around to submitting >>> to this list yet). >>> >>> The patch is at >>> https://src.fedoraproject.org/rpms/xen/blob/master/f/xen.ocaml.safe-strings.patch >>> with the related Fedora bug at >>> https://bugzilla.redhat.com/show_bug.cgi?id=1526703 >>> >>> Michael Young >> >> The patch looks good and I would prefer to take it than to use >> -unsafe-string which isn’t a solution in the long run. >> > > Hi Christian > > Is that an ack? > > Could you please in future explicitly give an Acked-by or Reviewed-by > tag so that committers know they can apply the proposed patch directly?
Sorry, I was assuming because this is an RFC that we are in a general discussion. Also, the patch was not part of the message. I still reviewed it. Reviewed-by: Christian Lindig <christian.lin...@citrix.com> — Christian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
