> On 26. Jan 2018, at 12:00, Wei Liu <wei.l...@citrix.com> wrote: > >> >> Reviewed-by: Christian Lindig <christian.lin...@citrix.com> >> > > Taking the above into consideration, does this tag still stand?
Thanks for the clarification. My tag still stands as the code in the patch is IMHO fine. Regarding Andrew’s comment: the bytes type was introduced in OCaml 4.02 - this makes the patch not compatible with OCaml 3.09.3. I still think that using the -unsafe-string option (introduced in OCaml 4.02) to keep strings mutable to avoid code changes is not going to work in the long run. The current OCaml version is 4.06. — Christian _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
