Hi Jan, > On 19 Oct 2021, at 12:25, Jan Beulich <jbeul...@suse.com> wrote: > > On 19.10.2021 13:12, Ian Jackson wrote: >> Bertrand Marquis writes ("[PATCH 0/3] Fixes: PCI devices passthrough on >> Arm"): >>> This patch serie is a follow-up after various findings on d59168dc05 >>> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of >>> agreed in [1]. >>> >>> It does the following: >>> - enable vpci_add_handlers on x86 and not only on arm >>> - remove __hwdom_init flag for vpci_add_handlers >>> - add missing vpci handler cleanup in error path during pci_device_add >>> and pci_device_remove >> >> Thanks. Roger, Jan, what do you think of this ? > > I'll get to this, but at the first glance I'd say that the change in > patch 1 coming before what patch 2 does is already a problem.
Because path 1 is actually introducing a bug solved by patch 2, I should have thought of that. I can either invert those 2 (or actually put patch 1 at the end) or merge patch 1 and 2 together. Bertrand > > Jan >