On 19.10.2021 12:40, Bertrand Marquis wrote:
> This patch serie is a follow-up after various findings on d59168dc05
> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
> agreed in [1].
>
> It does the following:
> - enable vpci_add_handlers on x86 and not only on arm
> - remove __hwdom_init flag for vpci_add_handlers
> - add missing vpci handler cleanup in error path during pci_device_add
> and pci_device_remove
>
> [1] https://marc.info/?l=xen-devel&m=163455502020100&w=2
>
> Bertrand Marquis (3):
> xen/arm: call vpci_add_handlers on x86
> xen/vpci: Remove __hwdom_init for vpci_add_handlers
> xen/pci: Add missing vpci handler cleanup
Imo all three changes need to be in a single patch. An option might be
to have first what is now patch 3, with CONFIG_ARM conditionals, which
the subsequent patch would then delete. But what is now patch 1 cannot
come before patch 2, and patch 2 alone would unduly impact x86 by
moving code from .init.text to .text for no reason. (Still it could
technically be done that way.)
But let me also comment patches 1 and 2 individually (patch 3 looks
okay, apart from the ordering issue).
Jan
