Hi Julien, > -----Original Message----- > From: Julien Grall <jul...@xen.org> > > Thanks for the clarification. I checked the code and found the xenheap_* > > variables are: > > xenheap_virt_start, xenheap_virt_end, xenheap_mfn_start, > > xenheap_mfn_end, xenheap_base_pdx. > > > > For clarification, do we need to change all of them to directmap_*? > > Good question.
:))) Thanks for your patience! > > > > > A pure renaming should be easy (and I guess also safe), but maybe I am > > overthinking because arm32 also uses xenheap_virt_end, > xenheap_mfn_start > > and xenheap_mfn_end. These variables refer to the real xenheap, I am not > > sure renaming these would reduce the readability for arm32. > > So on arm32, only the xenheap is direct mapped today. So I think it > would be fine to switch the name to "directmap_*". For extra clarify we > could add an alias for arm32 between "xenheap_*" and "directmap_*". Sounds good to me, I think I will try to add a separate patch for purely renaming all above-mentioned variables, then another patch for creating the alias for arm32. Hope you would fine with this plan. Kind regards, Henry > > Cheers, > > -- > Julien Grall
