Hi Ayan,
> On 23 Sep 2022, at 1:10 pm, Ayan Kumar Halder <ayank...@amd.com> wrote:
>
> Hi Rahul,
>
> On 23/09/2022 12:02, Rahul Singh wrote:
>> CAUTION: This message has originated from an External Source. Please use
>> proper judgment and caution when opening attachments, clicking links, or
>> responding to this email.
>>
>>
>> When ACPI is enabled and the system booted with ACPI, BUG() is observed
>> after merging the static event channel series. As there is not DT when
> [NIT] : s/not/no
Ack.
>> booted with ACPI there will be no chosen node because of that
>> "BUG_ON(chosen == NULL)" will be hit.
>>
>> (XEN) Xen BUG at arch/arm/domain_build.c:3578
> Is the bug seen on the gitlab ci ?
No, I found the issue while testing the ACPI boot. But going forward we will
add this in our internal ci.
>>
>> Move call to alloc_static_evtchn() under acpi_disabled check to fix the
>> issue.
>>
>> Fixes: 1fe16b3ed78a (xen/arm: introduce xen-evtchn dom0less property)
>> Signed-off-by: Rahul Singh <rahul.si...@arm.com>
>> ---
>> xen/arch/arm/setup.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
>> index 61b4f258a0..4395640019 100644
>> --- a/xen/arch/arm/setup.c
>> +++ b/xen/arch/arm/setup.c
>> @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset,
>> printk(XENLOG_INFO "Xen dom0less mode detected\n");
>>
>> if ( acpi_disabled )
>> + {
>> create_domUs();
>> -
>> - alloc_static_evtchn();
>> + alloc_static_evtchn();
>
> Can the code in alloc_static_evtchn() be guarded with "#ifndef CONFIG_ACPI
> ... endif" ?
Not required as acpi_disabled will take care of that. acpi_disabled variable is
used to avoid the CONFIG_ACPI.
Regards,
Rahul
