On 23.09.2022 14:10, Ayan Kumar Halder wrote:
> On 23/09/2022 12:02, Rahul Singh wrote:
>> --- a/xen/arch/arm/setup.c
>> +++ b/xen/arch/arm/setup.c
>> @@ -1166,9 +1166,10 @@ void __init start_xen(unsigned long boot_phys_offset,
>>           printk(XENLOG_INFO "Xen dom0less mode detected\n");
>>
>>       if ( acpi_disabled )
>> +    {
>>           create_domUs();
>> -
>> -    alloc_static_evtchn();
>> +        alloc_static_evtchn();
> 
> Can the code in alloc_static_evtchn() be guarded with "#ifndef 
> CONFIG_ACPI ... endif" ?

This wouldn't help the issue, but at best code size when !CONFIG_ACPI. When
CONFIG_ACPI=y, acpi_disabled might still be true, and hence the function
may still need skipping. Apart from this I'd also consider it odd to have
a non-ACPI function have such an #ifdef ...

Jan

Reply via email to