On 08.11.2022 17:16, Huang Rui wrote: > On Tue, Nov 08, 2022 at 11:56:17PM +0800, Jan Beulich wrote: >> On 08.11.2022 14:55, Roger Pau Monne wrote: >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image >>> from the firmware instead of doing it on the PCI ROM on the physical >>> device. >> >> I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere >> under Linux'es include/acpi/. I don't mind the addition that you're >> doing, but there needs to be a pointer to a sufficiently "official" >> spec. > > Thanks! In fact, this is defined by AMD atombios (VBIOS), we have up > streamed this in the Linux kenrel. You can see more details here: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/amd/include/atombios.h
I can see about two dozen lines at the bottom of that file, with effectively no helpful comments at all. I'm afraid I don't view this as "more details", let alone something replacing a spec. There at least needs to be enough to be sure that "VFCT" is really firmly reserved for this and only this purpose within the overall ACPI table name space. Jan
