On 08.11.2022 17:31, Roger Pau Monné wrote: > On Tue, Nov 08, 2022 at 04:56:17PM +0100, Jan Beulich wrote: >> On 08.11.2022 14:55, Roger Pau Monne wrote: >>> The VFCT ACPI table is used by AMD GPUs to expose the vbios ROM image >>> from the firmware instead of doing it on the PCI ROM on the physical >>> device. >> >> I can't find any mention of VFCT in the ACPI 6.3 spec, nor anywhere >> under Linux'es include/acpi/. I don't mind the addition that you're >> doing, but there needs to be a pointer to a sufficiently "official" >> spec. > > I've also asked for some kind of official spec, as I would assume it > should be in: > > https://uefi.org/acpi > > With the rest of tables not in the spec itself, but there's none. > > I could add a link to the Linux header, but that's suboptimal IMO. > > Are you fine with this as-is, or would you like me to elaborate about > the lack of an official spec in the commit description?
A pointer to the Linux bits is better than nothing, but as just said in reply to Ray there needs to be sufficient guarantee that "VFCT" really isn't going to be used for something else down the road. Jan
