On 28.02.2023 14:07, Oleksii wrote: > On Sat, 2023-02-25 at 16:47 +0000, Julien Grall wrote: >> On 24/02/2023 11:31, Oleksii Kurochko wrote: >>> --- a/xen/arch/arm/include/asm/bug.h >>> +++ b/xen/arch/arm/include/asm/bug.h >>> @@ -1,6 +1,8 @@ >>> #ifndef __ARM_BUG_H__ >>> #define __ARM_BUG_H__ >>> >>> +#include <xen/types.h> >> >> You are not adding new code in bug.h, so can you explain why this is >> now >> necessary? > I am not adding new code but inside 'struct bug_frame' there are > uint16_t and uint32_t which are defined in <xen/types.h>. > > And after <asm/bug.h> was changed to <xen/bug.h> it started to complain > on these types.
Wouldn't xen/bug.h want to include xen/types.h anyway, and then clearly before including asm/bug.h? Jan
