On 16.03.2023 01:26, Stefano Stabellini wrote: > On Wed, 15 Mar 2023, Andrew Cooper wrote: >> On 14/03/2023 4:30 pm, Jan Beulich wrote: >>> On 12.03.2023 08:54, Huang Rui wrote: >>>> From: Chen Jiqian <jiqian.c...@amd.com> >>> An empty description won't do here. First of all you need to address the >>> Why? >>> As already hinted at in the reply to the earlier patch, it looks like you're >>> breaking the intended IRQ model for PVH. >> >> I think this is rather unfair. >> >> Until you can point to the document which describes how IRQs are >> intended to work in PVH, I'd say this series is pretty damn good attempt >> to make something that functions, in the absence of any guidance. > > And to make things more confusing those calls are not needed for PVH > itself, those calls are needed so that we can run QEMU to support > regular HVM guests on PVH Dom0 (I'll let Ray confirm.)
Ah, but that wasn't said anywhere, was it? In which case ... > So technically, this is not breaking the PVH IRQ model. ... I of course agree here. But then I guess we may want to reject attempts for a domain to do any of this to itself. Jan
