On Fri, Jul 14, 2023 at 03:24:59AM +0200, Marek Marczykowski-Górecki wrote: > On Thu, Jul 13, 2023 at 05:16:40PM -0700, Elliott Mitchell wrote: > > The better to encourage moving to setting via string mode names. > > The numeric values needs to remain documented, otherwise interpreting > pre-existing configs (that may use them) will be tricky.
Problem is the way it is documented tends to encourage continued use of the numeric values (notice how reports irt Zen 4 mention "tsc_mode=1"). `parse_config_data()` suggests the appropriate string value, so nominally that should take care of older configurations. If "xen-tscmode" really needs to continue mentioning the numeric value, it should be in parentheses and with "old value" to suggest moving away from that. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sig...@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include <stddisclaimer.h> O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445
