On 14.07.2023 05:44, Elliott Mitchell wrote: > On Fri, Jul 14, 2023 at 03:24:59AM +0200, Marek Marczykowski-Górecki wrote: >> On Thu, Jul 13, 2023 at 05:16:40PM -0700, Elliott Mitchell wrote: >>> The better to encourage moving to setting via string mode names. >> >> The numeric values needs to remain documented, otherwise interpreting >> pre-existing configs (that may use them) will be tricky. > > Problem is the way it is documented tends to encourage continued use of > the numeric values (notice how reports irt Zen 4 mention "tsc_mode=1"). > > `parse_config_data()` suggests the appropriate string value, so nominally > that should take care of older configurations. If "xen-tscmode" really > needs to continue mentioning the numeric value, it should be in > parentheses and with "old value" to suggest moving away from that.
I'm not sure about "old" (we can't change the values without breaking backwards compatibility), but the numeric values will want mentioning alongside their spelled out names. As to mode 0 - that's the default mode, engaging emulation as necessary. See xen/include/public/arch-x86/cpuid.h Jan
