Hi Julien,
> -----Original Message-----
> Subject: Re: [PATCH v4 01/13] xen/arm64: head.S: Introduce
> enable_{boot,secondary}_cpu_mm
> >> prefer "enable_boot_cpu_mmu" as it is MMU specific as well.
> >
> > ...this, are the name suggested by Julien in [1], so probably I will stick
> > to these names, unless he would prefer the proposed names. I would
> > personally prefer the names that Julien suggested too, because from
> > the comments above these two functions, these functions not only
> > enable the MMU, but also turn on the d-cache, hence a more generic
> > name (using "mm"), is more appropriate here I guess.
>
> I have suggested those name because the two functions are meant to
> abstract the implementation between MPU and MMU (see [2] for the MPU).
>
> If we prefix them with *_mmu now, they will have to be renamed later on
> and will just introduce unnecessary churn.
Exactly, I fully agree with you. If we can do all the renaming in one shot to
fit
both MMU and MPU, we should definitely go for it.
Kind regards,
Henry
>
> >
> > [1] https://lore.kernel.org/xen-devel/c10bc254-ad79-dada-d5fb-
> 9ee619934...@xen.org/
>
> [2]
> https://gitlab.com/xen-project/people/henryw/xen/-
> /blob/mpu_v4/xen/arch/arm/arm64/mpu/head.S?ref_type=heads#L205
>
> --
> Julien Grall
