On 19.10.2023 12:35, Julien Grall wrote: > Hi, > > On 19/10/2023 10:05, Jan Beulich wrote: >> On 14.09.2023 16:56, Oleksii Kurochko wrote: >>> The patch introduces stub header needed for full Xen build. >>> >>> Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> >>> --- >>> xen/include/asm-generic/paging.h | 17 +++++++++++++++++ >>> 1 file changed, 17 insertions(+) >>> create mode 100644 xen/include/asm-generic/paging.h >>> >>> diff --git a/xen/include/asm-generic/paging.h >>> b/xen/include/asm-generic/paging.h >>> new file mode 100644 >>> index 0000000000..2aab63b536 >>> --- /dev/null >>> +++ b/xen/include/asm-generic/paging.h >>> @@ -0,0 +1,17 @@ >>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>> +#ifndef __ASM_GENERIC_PAGING_H__ >>> +#define __ASM_GENERIC_PAGING_H__ >>> + >>> +#define paging_mode_translate(d) (1) >>> +#define paging_mode_external(d) (1) > This is more a question for Jan, in the past I recall you asked the > macor to evaluate the argument. Shouldn't we do the same here?
Would certainly be desirable, and iirc actually needed for one of the Misra rules. > Also, I think we want to take the opportunity to convert to true. > Lastly, this seems to be using hard tab rather than soft tab. In Xen we > use the latter (unless this is a file imported from Linux). Oh, didn't even notice those; thanks for spotting. If we're at cosmetics, the parentheses also aren't needed here in the expansions of the macros. Jan
