On 23.10.2023 11:35, Oleksii wrote: > On Thu, 2023-10-19 at 11:35 +0100, Julien Grall wrote: >> On 19/10/2023 10:05, Jan Beulich wrote: >>> On 14.09.2023 16:56, Oleksii Kurochko wrote: >>>> The patch introduces stub header needed for full Xen build. >>>> >>>> Signed-off-by: Oleksii Kurochko <oleksii.kuroc...@gmail.com> >>>> --- >>>> xen/include/asm-generic/paging.h | 17 +++++++++++++++++ >>>> 1 file changed, 17 insertions(+) >>>> create mode 100644 xen/include/asm-generic/paging.h >>>> >>>> diff --git a/xen/include/asm-generic/paging.h b/xen/include/asm- >>>> generic/paging.h >>>> new file mode 100644 >>>> index 0000000000..2aab63b536 >>>> --- /dev/null >>>> +++ b/xen/include/asm-generic/paging.h >>>> @@ -0,0 +1,17 @@ >>>> +/* SPDX-License-Identifier: GPL-2.0-only */ >>>> +#ifndef __ASM_GENERIC_PAGING_H__ >>>> +#define __ASM_GENERIC_PAGING_H__ >>>> + >>>> +#define paging_mode_translate(d) (1) >>>> +#define paging_mode_external(d) (1) >> This is more a question for Jan, in the past I recall you asked the >> macor to evaluate the argument. Shouldn't we do the same here? > Could you please share a link? > I am not sure that I am in the context.
There's no particular link to be provided, I think. It is simply good practice to make sure macros evaluate each of the parameters exactly once. This is simply to avoid surprises at use sites, where function- like macro invocations - as that terminology says - look like function invocations, where every argument expression is also evaluated exactly once (and in unspecified order). Jan
