On 2023/12/4 15:58, Thomas Gleixner wrote: > On Fri, Nov 24 2023 at 18:31, Jiqian Chen wrote: >> When device on dom0 side has been reset, the vpci on Xen side >> won't get notification, so that the cached state in vpci is >> all out of date with the real device state. >> To solve that problem, this patch add a function to clear all > > Please get rid of 'this patch' all over the series. > > # grep -r 'This patch' Documentation/process/ Thanks. I will remove "this patch" or "I/we" in next version.
> >> vpci device state when device is reset on dom0 side. >> >> And call that function in pcistub_init_device. Because when >> we use "pci-assignable-add" to assign a passthrough device in >> Xen, it will reset passthrough device and the vpci state will >> out of date, and then device will fail to restore bar state. >> >> Signed-off-by: Jiqian Chen <jiqian.c...@amd.com> >> Signed-off-by: Huang Rui <ray.hu...@amd.com> > > This Signed-off-by chain is incorrect. > > Documentation/process/submitting-patches.rst has a full chapter about > S-O-B and the correct usage. I am the author of this series of patches, and Huang Rui transported the v1 to upstream. And now I transport v2. I am not aware that the SOB chain is incorrect. Do you have any suggestions? > > Thanks, > > tglx -- Best regards, Jiqian Chen.
