(reducing Cc list) On 04.12.2023 22:31, Stefano Stabellini wrote: > On Mon, 3 Dec 2023, Chen, Jiqian wrote: >>>> vpci device state when device is reset on dom0 side. >>>> >>>> And call that function in pcistub_init_device. Because when >>>> we use "pci-assignable-add" to assign a passthrough device in >>>> Xen, it will reset passthrough device and the vpci state will >>>> out of date, and then device will fail to restore bar state. >>>> >>>> Signed-off-by: Jiqian Chen <jiqian.c...@amd.com> >>>> Signed-off-by: Huang Rui <ray.hu...@amd.com> >>> >>> This Signed-off-by chain is incorrect. >>> >>> Documentation/process/submitting-patches.rst has a full chapter about >>> S-O-B and the correct usage. >> I am the author of this series of patches, and Huang Rui transported the v1 >> to upstream. And now I transport v2. I am not aware that the SOB chain is >> incorrect. >> Do you have any suggestions? > > I think he means that your Signed-off-by should be the second one of the > two as you are the one submitting the patch to the LKML
But that's not really correct either, as it then doesn't represent the sequence of events. The first S-o-b normally is the (original) author's, isn't it? Jan
