> On 14 May 2024, at 22:06, Julien Grall <jul...@xen.org> wrote: > > Hi, > > On 14/05/2024 08:53, Luca Fancellu wrote: >> Hi Julien, >> Thanks for having a look on the patch, >>> On 13 May 2024, at 22:54, Julien Grall <jul...@xen.org> wrote: >>> >>> Hi Luca, >>> >>> On 25/04/2024 14:11, Luca Fancellu wrote: >>>> Currently the code is listing device tree reserve map regions >>>> as reserved memory for Xen, but they are not added into >>>> bootinfo.reserved_mem and they are fetched in multiple places >>>> using the same code sequence, causing duplication. Fix this >>>> by adding them to the bootinfo.reserved_mem at early stage. >>> >>> Do we have enough space in bootinfo.reserved_mem for them? >> So we have 255 banks, in my experience I would say I’ve never saw too many >> reserved regions >> in the DT, maybe a couple, but I’ve always had to deal with embedded >> platforms. >> I’ve tested this one with ADLINK AVA board, n1sdp, Juno, raspberry pi, qemu, >> fvp. >> In your experience, have you seen any numbers that could be concerning? > I know in the past we had to bump the memory banks a few times. But as you > tested on a few platforms, I think we should be ok. > > It would be best if this patch goes sooner than later to allow wider testing > before we release 4.19. > > Acked-by: Julien Grall <jgr...@amazon.com>
Yes it would make sense, this patch makes sense on its own, would you/anyone commit it separately while I work on the second patch?
