On 22.05.2024 15:17, Andrew Cooper wrote: > From: Jan Beulich <jbeul...@suse.com> > > The emulation_count field is set only conditionally right now. Convert > all field setting to an initializer, thus guaranteeing that field to be > set to 0 (default initialized) when GUEST_PAGING_LEVELS != 3. > > Rework trace_shadow_emulate() to be consistent with the other trace helpers. > > Coverity-ID: 1598430 > Fixes: 9a86ac1aa3d2 ("xentrace 5/7: Additional tracing for the shadow code") > Signed-off-by: Jan Beulich <jbeul...@suse.com> > Acked-by: Roger Pau Monné <roger....@citrix.com>
Your additional changes look pretty much independent of what my original patch did. I don't mind the folding though, yet I think you need to add your own S-o-b as well. Then in turn Acked-by: Jan Beulich <jbeul...@suse.com> Jan