On 22/05/2024 2:47 pm, Jan Beulich wrote: > On 22.05.2024 15:17, Andrew Cooper wrote: >> trace_shadow_fixup() and trace_not_shadow_fault() both write out identical >> trace records. Reimplement them in terms of a common sh_trace_gl1e_va(). >> >> There's no need to pack the trace record, even in the case of PAE paging. > Isn't this altering the generated trace record for the 4-level case, in > size changing from 20 to 24 bytes?
Oh, eww. Yes it does. I'll need to rework with __packed still in place. ~Andrew
