On 04/07/18 09:17, Jan Beulich wrote:
>>>> On 03.07.18 at 22:55, <andrew.coop...@citrix.com> wrote:
>> Some open questions:
>>
>> * The position of libx86 in the source tree. It probably doesn't want to
>> live in its current location.
> So did you intentionally decide against ...
>
>> .gitignore | 2 +-
>> tools/include/Makefile | 15 ++
>> tools/libxc/Makefile | 14 +-
>> tools/libxc/include/xenctrl.h | 15 +-
>> tools/libxc/xc_cpuid_x86.c | 163 +++++++++++++++++---
>> tools/misc/xen-cpuid.c | 135 +++++++++++++++-
>> tools/tests/x86_emulator/x86-emulate.h | 2 +
>> xen/arch/x86/cpu/common.c | 2 +-
>> xen/arch/x86/cpuid.c | 32 +---
>> xen/arch/x86/domctl.c | 133 ++++++++++++++++
>> xen/arch/x86/msr.c | 4 +-
>> xen/arch/x86/sysctl.c | 101 ++++++++++++
>> xen/arch/x86/x86_emulate/x86_emulate.h | 7 +-
>> xen/common/Makefile | 1 +
>> xen/common/libx86/Makefile | 3 +
>> xen/common/libx86/cpuid.c | 226
>> +++++++++++++++++++++++++++
>> xen/common/libx86/libx86-private.h | 74 +++++++++
>> xen/common/libx86/msr.c | 134 ++++++++++++++++
>> xen/common/libx86/policies.c | 19 +++
> xen/lib/x86/... or lib/x86/... here and ...
>
>> xen/include/Makefile | 6 +-
>> xen/include/asm-x86/cpufeatures.h | 2 +-
>> xen/include/asm-x86/cpuid.h | 228
>> +---------------------------
>> xen/include/asm-x86/msr.h | 65 ++------
>> xen/include/public/arch-x86/xen.h | 18 +++
>> xen/include/public/domctl.h | 25 +++
>> xen/include/public/sysctl.h | 41 +++++
>> xen/include/{asm-x86 => xen/libx86}/cpuid.h | 103 +++++--------
>> xen/include/xen/libx86/msr.h | 78 ++++++++++
>> xen/include/xen/libx86/policies.h | 35 +++++
> xen/include/lib/x86/... or include/lib/x86/... here, as suggested
> on irc?
I tried, got stuck, then decided it would be better use of time to post
a v1 for review.
Once a general decision has been made, I'll try to remember/work out how
to use `git filter-branch` without it trying to delete my entire history.
> Personally I'd favor the top level variants, as that makes
> sufficiently clear that the code is neither specific to the hypervisor
> nor specific to the tools.
That's the concern I've got with the top level variant. I view this as
hypervisor code which we also want to use in libxc, rather than
specifically separate code.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
