On 16/07/18 10:23, Jan Beulich wrote: >>>> On 13.07.18 at 22:03, <andrew.coop...@citrix.com> wrote: >> Begin to untangle the header dependency tangle by moving definition of >> struct cpuid_leaf out of x86_emulate.h into the new cpuid.h. >> >> Additionally, plumb the header through to libxc. This is technically a >> redundant include at this point, but it helps build-test the later changes, >> and will be used eventually. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >> Signed-off-by: Roger Pau Monné <roger....@citrix.com> >> Reviewed-by: Wei Liu <wei.l...@citrix.com> >> --- >> CC: Jan Beulich <jbeul...@suse.com> >> CC: Roger Pau Monné <roger....@citrix.com> >> CC: Sergey Dyasli <sergey.dya...@citrix.com> >> CC: Ian Jackson <ian.jack...@eu.citrix.com> >> >> Note concerning the positioning of libx86. It turns out after trying to move >> it elsewhere that the movement is prohibitive because of the way Xen headers >> are included by the tools. > If there's really something preventing it to be placed better, then I'm > certainly willing to give my ack here, but I'd like to have a more clear > understanding of what issue(s) you are talking about above.
It is better explained in the context of the following patch. Moving to asm-x86/libx86/ breaks the autogen safety because the entire tree hierarchy is made available with a single directory symlink. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
