On 22.12.2025 17:37, Oleksii Kurochko wrote:
> +static int vsbi_legacy_ecall_handler(unsigned long eid, unsigned long fid,
> + struct cpu_user_regs *regs)
> +{
> + int ret = 0;
> +
> + switch ( eid )
> + {
> + case SBI_EXT_0_1_CONSOLE_PUTCHAR:
> + vsbi_print_char(regs->a0);
> + break;
> +
> + case SBI_EXT_0_1_CONSOLE_GETCHAR:
> + ret = SBI_ERR_NOT_SUPPORTED;
> + break;
> +
> + default:
> + /*
> + * TODO: domain_crash() is acceptable here while things are still
> under
> + * development.
> + * It shouldn't stay like this in the end though: guests should not
> + * be punished like this for something Xen hasn't implemented.
> + */
> + domain_crash(current->domain,
> + "%s: Unsupported ecall: FID: #%lx, EID: #%lx\n",
Hmm, wait - patch 1 says you would consistently use #%lu for FIDs. I can adjust
while committing, unless you tell me not to.
Jan
