On 22.01.2026 10:49, Jan Beulich wrote: > On 21.01.2026 16:47, Alejandro Vallejo wrote: >> There's some assumptions as to which targets may be init-only. But >> there's little reason to preclude libraries from being init-only. >> >> Signed-off-by: Alejandro Vallejo <[email protected]> >> Reviewed-by: Jan Beulich <[email protected]> > > I can't tell (yet) what it is, but as per CI something's clearly wrong with > this > change. Both xilinx-smoke-dom0less-arm64-* and qemu-smoke-dom0*-debug* fail > with > it in place. qemu-smoke-dom0-arm64-gcc (no "debug") was fine, suggesting it > may > be an early assertion triggering.
Or an early UBSAN failure. I think ... >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -130,9 +130,9 @@ endif >> >> targets += $(targets-for-builtin) >> >> -$(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): CFLAGS-y += >> -DINIT_SECTIONS_ONLY >> +$(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y) $(lib-y)): CFLAGS-y += >> -DINIT_SECTIONS_ONLY >> >> -non-init-objects = $(filter-out %.init.o, $(obj-y) $(obj-bin-y) $(extra-y)) >> +non-init-objects = $(filter-out %.init.o, $(obj-y) $(obj-bin-y) $(extra-y) >> $(lib-y)) ... this is the problem: You're _adding_ library files here which weren't there before. Why $(lib-y) isn't here I don't really known, but as per the CI results there must be a reason for this. Jan
