On 2026-01-22 13:50, Andrew Cooper wrote:
On 22/01/2026 8:27 am, Jan Beulich wrote:
On 21.01.2026 16:47, Alejandro Vallejo wrote:
--- a/docs/misra/exclude-list.json
+++ b/docs/misra/exclude-list.json
@@ -121,10 +121,6 @@
"rel_path": "common/bunzip2.c",
"comment": "Imported from Linux, ignore for now"
},
- {
- "rel_path": "common/earlycpio.c",
- "comment": "Imported from Linux, ignore for now"
- },
{
"rel_path": "common/gzip/*",
"comment": "Imported from Linux, ignore for now"
Judging from Andrew's
https://gitlab.com/xen-project/hardware/xen-staging/-/pipelines/2277362625
this doesn't quite work. As I had expected, since the file is compiled
unconditionally now in its new location, some violations are now also
unconditionally reported. (Some, checked for at linking time only, may
not
be reported anymore for the *-amd analysis jobs.)
Yeah, in hindsight this seems obvious, given that we're compiling then
discarding.
There are two options:
1. Use an earlier form which adds the new location to the exclude list
(Still needs to be in this patch for bisectibility.)
2. Fix up the violations first (only 6 in total)
Two of the violations look easy to fix, two need the deviation for
octal
numbers, but two essentially-char violations look to be hard. The
logic
is doing ASCII manipulation in what I would consider to be the
appropriate/canonical way, but Eclair does not like the mixture of ints
and character literals.
I dislike option 1, but as (contrary to my expectations) this is
interfering with the *-amd build, I'll tolerate it.
I agree that Solution 1 is the easiest to implement. An alternative
could be to fix the regressions for R7.1 and R20.7 (they're trivial)
regardless and add casts to sidestep MISRA for R10.2.
--
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253
