On 11/21/18 3:21 PM, Andrew Cooper wrote: > Drop the ap2m_active boolean, and consistently use the unlocking form: > > if ( p2m != hostp2m ) > __put_gfn(p2m, gfn); > __put_gfn(hostp2m, gfn); > > which makes it clear that we always unlock the altp2m's gfn if it is in use, > and always unlock the hostp2m's gfn. This also drops the ternary expression > in the logdirty case. > > Extend the logdirty comment to identify where the locking violation is liable > to occur. > > No (intended) overall change in behaviour. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Reviewed-by: Razvan Cojocaru <rcojoc...@bitdefender.com> FWIW, I've also applied this and the previous two patches I've reviewed to the end of my altp2m series and gave them a spin with introspection with no apparent problems. Thanks, Razvan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
