On 23/11/2018 08:23, Jan Beulich wrote: >>>> On 22.11.18 at 18:46, <andrew.coop...@citrix.com> wrote: >> On 22/11/2018 14:51, Jan Beulich wrote: >>>> @@ -220,12 +219,18 @@ void guest_iommu_add_ppr_log(struct domain *d, u32 >>>> entry[]) >>>> unmap_domain_page(log_base); >>>> >>>> guest_iommu_deliver_msi(d); >>>> + >>>> +out: >>> Please indent by at least one blank (same further down). >> I thought you've said that you're no longer using an obsolete version of >> diff. > I don't think I've ever said so, and I don't think it matters much what > I personally use.
The only reason we have this quirk of a coding style is because you insisted when David was putting together CODING_STYLE, and the reason you gave was to work around versions of `diff -u` which mistook the case label for the function name when creating the unified header. v1 of David's patch very specifically didn't have the one space, because he was actually trying to get rid of that, as it was (and still is) completely unexpected for new developers, and a frequent source of curt review responses. If this is no longer a concern, can I suggest we update CODING_STYLE. This is one particular divergence from more normal styles which doesn't add to code clarity in any way I can spot. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
