George Dunlap writes ("[PATCH 5/9] libxl: Do root checks once in
libxl__domain_get_device_model_uid"):
> At the moment, we check for equivalence to literal "root" before
> deciding whether to add the `runas` command-line option to QEMU. This
> is unsatisfactory for several reasons.
I was in two minds about the gotos in the earlier version of this
patch. But here they are getting quite out of hand.
I know that in the hypervisor this kind of thing is tolerated (wrongly
IMO) but can we please not have it here.
This may mean splitting stuff out into a sub-function. That could be
done some time between "Move dm user determination logic into a helper
function" and this patch I guess.
Sorry,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
