> On Nov 28, 2018, at 4:39 PM, Ian Jackson <ian.jack...@citrix.com> wrote:
>
> George Dunlap writes ("[PATCH 5/9] libxl: Do root checks once in
> libxl__domain_get_device_model_uid"):
>> At the moment, we check for equivalence to literal "root" before
>> deciding whether to add the `runas` command-line option to QEMU. This
>> is unsatisfactory for several reasons.
>
> I was in two minds about the gotos in the earlier version of this
> patch. But here they are getting quite out of hand.
>
> I know that in the hypervisor this kind of thing is tolerated (wrongly
> IMO) but can we please not have it here.
It is a bit strange having to work with one maintianer who thinks a handful of
simple gotos is an issue, and another maintainer who thinks having switch case
statements appear in the middle of if() { } blocks is perfectly normal. :-)
> This may mean splitting stuff out into a sub-function. That could be
> done some time between "Move dm user determination logic into a helper
> function" and this patch I guess.
I’m afraid you’re going to have to give me a bit more guidance here: It’s not
clear to me what would be split into a sub-function, and how that would make
the code easier to follow while avoiding unnecessary code duplication.
Do you propose replacing “goto root_check;” with “root_check(); goto out;” in
all locations? Or something else?
-George
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
