On 2019/1/15 1:17, Jan Beulich wrote:
>>>> On 20.12.18 at 14:14, <pu...@hygon.cn> wrote:
>> Add Hygon Dhyana support to the acpi cpufreq subsystem by using the code
>> path of AMD.
>
> ... cpufreq and cpuidle subsystems ...
Thanks for the correction.
>> @@ -660,8 +661,9 @@ int cpufreq_cpu_init(unsigned int cpuid)
>> {
>> int ret;
>>
>> - /* Currently we only handle Intel and AMD processor */
>> + /* Currently we only handle Intel and AMD and Hygon processor */
>
> Please replace the first "and" by a comma.
OK.
>> if ( (boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) ||
>> + (boot_cpu_data.x86_vendor == X86_VENDOR_HYGON ) ||
>> (boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) )
>> ret = cpufreq_add_cpu(cpuid);
>> else
>
> At the very least here I think you want to change to switch().
I think there is no need to change if() to switch(), because if() looks
concise enough here. Also the change will generate a bigger patch.
--
Regards,
Pu Wen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
