On 27/06/2019 10:33, Roger Pau Monne wrote: > Note that those sections when not prefixed with .init are already > handled by the more general .rodata.* matching pattern in the .rodata > output section. > > Signed-off-by: Roger Pau Monné <roger....@citrix.com>
So, in hindsight, we'll never get .cst in .data, because of the "constant" in the name, which rules out a lot of my first attemt. As this does resolve the problem, Acked-by: Andrew Cooper <andrew.coop...@citrix.com> However ... > --- > Cc: Stefano Stabellini <sstabell...@kernel.org> > Cc: Julien Grall <julien.gr...@arm.com> > Cc: Jan Beulich <jbeul...@suse.com> > Cc: Andrew Cooper <andrew.coop...@citrix.com> > Cc: Wei Liu <w...@xen.org> > --- > xen/arch/arm/xen.lds.S | 1 + > xen/arch/x86/xen.lds.S | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S > index e664c4441a..b636d9f223 100644 > --- a/xen/arch/arm/xen.lds.S > +++ b/xen/arch/arm/xen.lds.S > @@ -156,6 +156,7 @@ SECTIONS > *(.init.rodata) > *(.init.rodata.rel) > *(.init.rodata.str*) > + *(.init.rodata.cst*) ... .init is just a grouping prefix, so I'd recommend that we treat .init.rodata in exactly the same way as we treat .rodata, so I'd suggest turning this into *(.init.rodata) *(.init.rodata.*) to match the regular .rodata. This can easily be adjusted on commit, to save yet-another-round. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
