On Thu, Jun 27, 2019 at 05:25:06AM -0600, Jan Beulich wrote: > >>> On 27.06.19 at 12:53, <andrew.coop...@citrix.com> wrote: > > On 27/06/2019 10:33, Roger Pau Monne wrote: > >> --- a/xen/arch/arm/xen.lds.S > >> +++ b/xen/arch/arm/xen.lds.S > >> @@ -156,6 +156,7 @@ SECTIONS > >> *(.init.rodata) > >> *(.init.rodata.rel) > >> *(.init.rodata.str*) > >> + *(.init.rodata.cst*) > > > > ... .init is just a grouping prefix, so I'd recommend that we treat > > .init.rodata in exactly the same way as we treat .rodata, so I'd suggest > > turning this into > > > > *(.init.rodata) > > *(.init.rodata.*) > > > > to match the regular .rodata. > > Or, as suggested elsewhere, make .rodata use less wide matching, > like we do for .init.rodata.
I'm happy to handle .init.rodata subsections as Xen currently handles .rodata subsections. There are no custom subsections explicitly added to either .rodata or .init.rodata, and if we start adding such subsections explicitly the linker script will likely need modifications anyway to mark the start and end of those subsections in the final binary, or the default placement of the wider wildcard will be already fine. Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
