On Wed, Jan 22, 2020 at 02:44:40PM +0000, Paul Durrant wrote: > Currently both xl and libxl have internal definitions of INVALID_DOMID > which happen to be identical. However, for the purposes of describing the > behaviour of libxl_domain_create_new/restore() it is useful to have a > specified invalid value for a domain id. > > This patch therefore moves the libxl definition from libxl_internal.h to > libxl.h and removes the internal definition from xl_utils.h. The hardcoded > '-1' passed back via domcreate_complete() is then updated to INVALID_DOMID > and comment above libxl_domain_create_new/restore() is accordingly > modified.
Urg, it's kind of ugly to add another definition of invalid domid when there's already DOMID_INVALID in the public headers. I guess there's a reason I'm missing for not using DOMID_INVALID instead of introducing a new value? If so could this be mentioned in the commit message? Thanks, Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
