On 19/01/2021 14:38, Roger Pau Monné wrote: > On Fri, Jan 15, 2021 at 11:10:44PM +0000, Andrew Cooper wrote: >> So all the moving parts are in one function. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> >> --- >> CC: Jan Beulich <jbeul...@suse.com> >> CC: Roger Pau Monné <roger....@citrix.com> >> CC: Wei Liu <w...@xen.org> >> CC: Marek Kasiewicz <marek.kasiew...@3mdeb.com> >> CC: Norbert Kamiński <norbert.kamin...@3mdeb.com> >> CC: Michal Zygowski <michal.zygow...@3mdeb.com> >> CC: Piotr Krol <piotr.k...@3mdeb.co> >> CC: Krystian Hebel <krystian.he...@3mdeb.com> >> CC: Daniel P. Smith <dpsm...@apertussolutions.com> >> CC: Rich Persaud <pers...@gmail.com> >> CC: Christopher Clark <christopher.w.cl...@gmail.com> >> --- >> xen/arch/x86/smpboot.c | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c >> index 67e727cebd..9eca452ce1 100644 >> --- a/xen/arch/x86/smpboot.c >> +++ b/xen/arch/x86/smpboot.c >> @@ -426,6 +426,13 @@ static int wakeup_secondary_cpu(int phys_apicid, >> unsigned long start_eip) >> int maxlvt, timeout, i; >> >> /* >> + * Some versions of tboot might be able to handle the entire wake >> sequence >> + * on our behalf. >> + */ >> + if ( tboot_in_measured_env() && tboot_wake_ap(phys_apicid, start_eip) ) > I think you are missing a ! in front of tboot_wake_ap?
Oh - so I am. That function is totally backwards. Fixed. ~Andrew
