Sorry, but is not my code, this code arrived here from harbour,
is possible need HB_IS_NUMBER instead of HB_IS_NUMERIC

   else if( HB_IS_NUMBER( pKey ) )
   {
      dValue = hb_itemGetND( pKey );
      pszKey = ( UNSIGNED8* ) &dValue;
      u16KeyLen = ( UNSIGNED16 ) sizeof( double );
      u16KeyType = ADS_DOUBLEKEY;
   }
   else if( HB_IS_DATE( pKey ) )
   {
      dValue = ( double ) hb_itemGetDL( pKey );
      pszKey = ( UNSIGNED8* ) &dValue;
      u16KeyLen = ( UNSIGNED16 ) sizeof( double );
      u16KeyType = ADS_DOUBLEKEY;
   }
   else if( HB_IS_LOGICAL( pKey ) )

Please upload yourself this changes ;)

Is better to use HB_IS_NUMBER( pKey ), beacuse HB_IT_ system can be changed to add
new type T as datetime instead of use actual flag.

But i need aprove of the rest of developers.

PLEASE contact with me at miguelmarch...@hotmail.com (MESSENGER account) to talk it or another questions related

Best regards,
Miguel Angel Marchuet

bhays escribió:

Miguel:

 

I’m trying to look over the changes to ads1.c to help with the character field length problem.

There are a few changes I don’t understand.

 

Why was the explicit NUMERIC test

   else if( hb_itemType( pKey ) & HB_IT_NUMERIC )

changed to

   else if( HB_IS_NUMERIC( pKey ) )

?

 

Is this your change?

 

HB_IS_NUMERIC( pKey ) includes DATES and single-byte strings.

I have lots of single character fields, some with indexes on them, and

I would expect errors to occur if these are treated like numbers at the

C level when interacting with ADS index keys and scopes.

Was this change done explicitly to include these other types, or was

someone perhaps thinking it was functionally the same but cleaner code?

 

Thanks,

 

--

Brian Hays

Abacus Data Systems, Inc.

 



__________ Information from ESET Smart Security, version of virus signature database 4247 (20090715) __________

The message was checked by ESET Smart Security.

http://www.eset.com

------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge


__________ Information from ESET Smart Security, version of virus signature database 4247 (20090715) __________

The message was checked by ESET Smart Security.

http://www.eset.com

  

_______________________________________________ xHarbour-developers mailing list xHarbour-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xharbour-developers __________ Information from ESET Smart Security, version of virus signature database 4247 (20090715) __________ The message was checked by ESET Smart Security. http://www.eset.com


__________ Information from ESET Smart Security, version of virus signature database 4247 (20090715) __________

The message was checked by ESET Smart Security.

http://www.eset.com
------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
xHarbour-developers mailing list
xHarbour-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xharbour-developers

Reply via email to