James Bates wrote:
Mike, very useful patch. I was thinking of fixing that issue myself some time.


Cheers!

>
> There's one snag though: when converting byte arrays to strings, you
> assume the byte arrays are in UTF-8, which would have been an
> intelligent choice.

Hmm, that's what was happening at that point already - I just set the attribute value as a variable because it was potentially getting used twice.

>
> Shall I make make the change and commit the patch, guys?
>

By all means, clean it up.. so it should just be "new String(b)", then? There's another point a bit further down where a new UTF-8 encoded string is instantiated, you probably want to fix that as well..

--
Mike Gratton <[EMAIL PROTECTED]>, <http://web.vee.net/>
"Every motive escalate."



Reply via email to