Re: cvs commit: xml-xindice/java/src/org/apache/xindice/server/rpc/messages GetCollectionMeta.java GetDocumentMeta.java SetCollectionMeta.java SetDocumentMeta.java

27 Dec 2002 21:09:43 -0000 

  Modified:    config   system.xml
               java/src/org/apache/xindice/core Collection.java
                        Database.java
               java/src/org/apache/xindice/server/rpc
                        RPCDefaultMessage.java
  Added:       java/src/org/apache/xindice/core MetaSystemCollection.java
               java/src/org/apache/xindice/core/meta MetaData.java
                        TimeRecord.java package.html
               java/src/org/apache/xindice/server/rpc/messages
                        GetCollectionMeta.java GetDocumentMeta.java
                        SetCollectionMeta.java SetDocumentMeta.java
  Log:
  Implementation of MetaData storage for Xindice.  This
  topic has been extensively discussed on the mailing list. Please
  see the following threads from the mailing list for more information


1) sorry to always repeat the same thing but "Where are the tests"?
Can't this code fail?

2) I've set up PMD to check for code quality and it looks like you
didn't bother run it:

org/apache/xindice/core/MetaSystemCollection.java 63 Avoid duplicate
imports such as 'org.apache.xindice.util.Configuration'
org/apache/xindice/core/MetaSystemCollection.java 216 Avoid empty catch
blocks
org/apache/xindice/core/MetaSystemCollection.java 286 Avoid empty catch
blocks
org/apache/xindice/core/MetaSystemCollection.java 77 Avoid unused
imports such as 'File'
org/apache/xindice/core/meta/MetaData.java 634 Avoid unused local
variables such as 'prefix'
org/apache/xindice/core/meta/TimeRecord.java 63 Avoid unused imports
such as 'Hashtable'
org/apache/xindice/server/rpc/messages/GetCollectionMeta.java 70 Avoid
unused imports such as 'DOMImplementationImpl'
org/apache/xindice/server/rpc/messages/GetCollectionMeta.java 63 Avoid
unused imports such as 'Database'
org/apache/xindice/server/rpc/messages/GetDocumentMeta.java 63 Avoid
unused imports such as 'Database'
org/apache/xindice/server/rpc/messages/SetCollectionMeta.java 64 Avoid
unused imports such as 'Database'
org/apache/xindice/server/rpc/messages/SetDocumentMeta.java 64 Avoid
unused imports such as 'Database'

3) where is the documentation?  Is metadata such an easy topic?

Last mail from the Grinch.

-Vladimir

--
Vladimir R. Bossicard
Apache Xindice - http://xml.apache.org/xindice

Reply via email to