Vadim, It does seem cleaner to follow your approach in xindice.war.bat.
A difference is that the war version has a very good default for XINDICE_HOME. Requiring users of xindice.bat to define XINDICE_HOME seems a small detail and would allow xindice.bat to be simplified. In the latest xindice.bat, XINDICE_HOME defaults to the current directory, in the final case, if there is a config subdirectory. Ironically, I do not think that a configuration file in that directory would be used as the code is now. Perhaps xindice.bat should have a line added: if "%XINDICE_CONFIGURATION%" == "" set XINDICE_CONFIGURATION=%XINDICE_HOME%\config\system.xml and the java command should have: "-Dxindice.configuration=%XINDICE_CONFIGURATION% " added. And the same changes for xindice.war.bat? /Neil -----Original Message----- From: Vadim Gritsenko [mailto:[EMAIL PROTECTED] Sent: Thursday, January 15, 2004 2:15 PM To: [EMAIL PROTECTED] Subject: Re: cvs commit: xml-xindice/bin xindice.war.bat xindice.war.sh xindice.bat Neil Cook wrote: >Vadim, > >In xindice.bat, you might consider using the environment variable >%ProgramFiles% when searching for the Xindice installation directory. I >think that "Program Files" might be translated on non-English versions of >Windows. > > I think I'll remove all funky "Program Files" business out of bat files and will attempt to autodetect script directory location in the same way as xml-xindice/xindice.bat does this. Take a look at the xindice.war.bat (intended to be run from $TOMCAT/webapps/xindice/WEB-INF/) - it does not have any "Program Files" anymore. What do you think? Vadim
