Neil Cook wrote:
Vadim,
It does seem cleaner to follow your approach in xindice.war.bat.
Good.
A difference is that the war version has a very good default for XINDICE_HOME. Requiring users of xindice.bat to define XINDICE_HOME seems a small detail and would allow xindice.bat to be simplified.
In the latest xindice.bat, XINDICE_HOME defaults to the current directory, in the final case, if there is a config subdirectory. Ironically, I do not think that a configuration file in that directory would be used as the code is now.
Perhaps xindice.bat should have a line added:
If you mean xml-xindice\bin\xindice.bat - I've not started yet rewriting it... If you mean xml-xindice\xindice.bat - this is to start xindice with jetty, and currently it is not included in any distro at all... I think it should be included with src distro.
So, what xindice.bat do you mean and for what distro? :-)
if "%XINDICE_CONFIGURATION%" == "" set XINDICE_CONFIGURATION=%XINDICE_HOME%\config\system.xml
and the java command should have:
"-Dxindice.configuration=%XINDICE_CONFIGURATION% " added. And the same
changes for xindice.war.bat?
xindice.war.bat generally does not need xindice.configuration, because it (generally) goes over XMLRPC. But for those moments when you want to access DB locally... Yes, it can be added. Ok, I've added it to the .war.bat file.
PS Do you want to tweak those bat/sh files? You can send in a patch ;-)
Vadim
