Tilman Sauerbeck wrote:
Let me know what you think.

Looking good. Thats it?

The "xmmsc_broadcast_configval_changed -> xmmsc_broadcast_config_value_changed" made me think about signals. Should we go all the way and use xmmsc_config_value_changed_broadcast? Guess that would mean a whole lot of renames.



Second issue: I think we need to decide on the name of the output IPC
object. On the server side, it's called output, but on the client side
it's called playback (XMMS_IPC_OBJECT_OUTPUT vs xmmsc_playback_play etc).
I suggest we call it playback in the future, since it seems like a fine
name and won't cause API breakage. Objections?

Go for it. Works fine for volume too, xmmsc_playback_volume_get


 anders


--
_______________________________________________
Xmms2-devel mailing list
Xmms2-devel@lists.xmms.se
http://lists.xmms.se/cgi-bin/mailman/listinfo/xmms2-devel

Reply via email to