On 2/12/2015 18:12 , Keith Packard wrote:
Peter Hutterer <peter.hutte...@who-t.net> writes:

disable _the_ XTEST extension? in at least two places. One comment, just to
be annoying: I'd prefer this split in two patches, with the second one just
toggling the true/false switch for RECORD and having the git subject line of
"Disable RECORD by default". Makes it much easier to find in the log than
hiding it in the first paragraph.
Reviewed-by: Peter Hutterer <peter.hutte...@who-t.net> otherwise

Thanks for the suggestions; I'll get new patches out with these
changes.

but note that syndaemon is a common user of RECORD, if it is disabled we
fall back to regular querying of the keyboard state with all its
drawbacks (unnecessary wakeups, missing of some key events, etc.)
with the two other patches you're breaking the backup option, so anyone not
using libinput will lose the disable-while-typing feature.

Sounds like we need a sync timer for keyboard idle time then, and then
updates to syndaemon.

we have device idle timers, a client could just look at the idle timers of each device with a XIKeyClass and subscribe to those. Unfortunately the most common invocation of syndaemon is with the flag that ignores modifier keys so you can ctrl+click without having the touchpad disabled after pressing ctrl. You can't get that behaviour with idletimers and I'm a bit scared of any idletimer implementation that does that :)

Really, the only sensible solution is what we did with libinput, but that's not going to find its way back into synaptics.

Cheers,
  Peter

_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to