Michel Dänzer <mic...@daenzer.net> writes: Here's another review, now that I've more carefully looked at the other two patches.
> + if (!flip_window || !flip_pixmap) > + return; In the original code, this didn't abort the operation entirely... This operation would have been skipped: > + present_set_tree_pixmap(flip_window, flip_pixmap, screen_pixmap); But this operation would not: > + present_set_tree_pixmap(screen->root, NULL, screen_pixmap); Reading the rest of the code, I can't find a case which could call this with a null flip_window or flip_pixmap; perhaps it would be better to stick an assert that they are both set at the top of this function? -- -keith
signature.asc
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
