Michel Dänzer <mic...@daenzer.net> writes: > From: Michel Dänzer <michel.daen...@amd.com> > > The unnecessary FlushCallback calls could cause significant performance > degradation with compositing.
Yeah, we do need a flush callback in drivers to ensure that damage events aren't sent without the rendering being flushed. A block handler used to be sufficient as WriteToClient "never" actually wrote anything, and all output was delayed until FlushAllOutput, which happens after the BlockHandler call in WaitForSomething. It should, however, be sufficient to simply move the callback in FlushAllOutput after the check for 'newoutput'; newoutput should only ever be set if there is output to deliver. -- -keith
signature.asc
Description: PGP signature
_______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel