[ 
https://issues.apache.org/jira/browse/YARN-193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhijie Shen updated YARN-193:
-----------------------------

    Attachment: YARN-193.6.patch

Based on @Hitesh's previous patch, I've made the following changes in the 
newest one:

1. Modify the boundary case of judging valid resource value ("< 0" => "<= 0").

2. maxMem doesn't need to be the multiple times of minMem.

3. To fix YARN-382, in RMAppManager, AM CLC still need to be updated after 
request normalization is executed, such that AM CLC knows the updated resource 
if possible, which will be equal to the resource of the allocated container. To 
ensure the equivalence, assert is added in 
RMAppAttemptImpl$AMContainerAllocatedTransition. Changes in YARN-370 is also 
reverted.

Therefore, if this jira is fixed, YARN-382 can be fixed as well.

4. InvalidResourceException, which is extended from IOException, is created and 
used when the requested resource is invalid in terms of its numbers. Modify the 
related functions to either throw or capture the exceptions. In particular, in 
the transitions of RMAppAttemptImpl, when the exception is captured the attempt 
will transit to FAILED state.

When YARN-142 gets fixed, the customized exception need to be updated.

5. Reorganize the code.

6. Add more test cases.

Comments, please. Thanks!
                
> Scheduler.normalizeRequest does not account for allocation requests that 
> exceed maximumAllocation limits 
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-193
>                 URL: https://issues.apache.org/jira/browse/YARN-193
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.0.2-alpha, 3.0.0
>            Reporter: Hitesh Shah
>            Assignee: Zhijie Shen
>         Attachments: MR-3796.1.patch, MR-3796.2.patch, MR-3796.3.patch, 
> MR-3796.wip.patch, YARN-193.4.patch, YARN-193.5.patch, YARN-193.6.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to