[
https://issues.apache.org/jira/browse/YARN-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655012#comment-13655012
]
Vinod Kumar Vavilapalli commented on YARN-660:
----------------------------------------------
Quick comment:
h4.Cookies:
Seems like the cookies aren't used by the library itself. Is that true? If so,
why does the library need to provide StoredContainerRequest, can't the users
implement one and pass it on?
h4. Generics/typing:
Adding in this type information for every AMRMClient is an unnecessary burden
for most cases IMO. Users can skip explicit typing, but the compiler will warn
unnecessarily. Can't this be done without the explicit typing?
I can see that the new API getMatchingRequests is useful, +1 for that. What if
we just return a Collection<ContainerRequest> all the time, and get clients to
do explicit conversion if they care about adding in more information.
Similarly, add and remove APIs already take in a ContainerRequest, you can just
continue to pass sub-types of ContainerRequest when you want to. I quickly did
this on your latest patch, removing all typing in the library, it works.
Have to dig deeper into the client libraries, haven't looked at them at all.
> Improve AMRMClient with cookies and matching requests
> -----------------------------------------------------
>
> Key: YARN-660
> URL: https://issues.apache.org/jira/browse/YARN-660
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.0.5-beta
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Fix For: 2.0.5-beta
>
> Attachments: YARN-660.1.patch, YARN-660.2.patch, YARN-660.3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
