[ 
https://issues.apache.org/jira/browse/YARN-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655134#comment-13655134
 ] 

Vinod Kumar Vavilapalli commented on YARN-660:
----------------------------------------------

Okay, I took this as an opportunity to learn more about AMRMClient. Have seen 
other API issues in AMRMCient, will file tickets.

Clearly we need a validation of the APIs like you are doing in TEZ. We should 
definitely try to change MR AppMaster to optionally use AMRMClient.

Coming back to current issues at hand. Correct me if I am wrong, but it looks 
like these StoredContainerRequests are only useful if I have a Task in my job 
which needs a container and the returned container will only be used by that 
task? If yes
 - That is a very narrow use-cases. May be the simplest use-case which we can 
address by building on top of AMRMClient, like for e.g., a SimpleAMRMClient 
which only deals with a container at a time.
 - AMRMClient should be built for the more common use-cases - I give you these 
requests, you tell me when the containers are allocated, I'll do the second 
schedule pass according to my own logic.

Again, I think I should see a more concrete usage. The current test-case is 
clearly not doing enough to explain how it is usable - we can implement a 
simple job which has tasks and needs containers inside this test-case and then 
illustrate the library usage.
                
> Improve AMRMClient with cookies and matching requests
> -----------------------------------------------------
>
>                 Key: YARN-660
>                 URL: https://issues.apache.org/jira/browse/YARN-660
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>    Affects Versions: 2.0.5-beta
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>             Fix For: 2.0.5-beta
>
>         Attachments: YARN-660.1.patch, YARN-660.2.patch, YARN-660.3.patch, 
> YARN-660.4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to