[
https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15630958#comment-15630958
]
Jian He commented on YARN-5611:
-------------------------------
- can you add comments about the type of the timeout value ?
{code}
/**
* Set the <code>ApplicationTimeouts</code> for the application in seconds.
* All pre-existing Map entries are cleared before adding the new Map.
*
{code}
- Revert RMAppEventType change
- for roll back, there's no need to use the future object.
{code}
// do roll back
future = SettableFuture.create();
app.updateApplicationTimeout(RMAppUpdateType.ROLLBACK, newExpireTime,
currentApplicationTimeouts, future);
// Roll back can fail only when application is in completing state.
try {
Futures.get(future, YarnException.class);
} catch (YarnException e) {
LOG.warn("Roll back failed for an application "
+ app.getApplicationId() + " with message" + e.getMessage());
}
{code}
- fix indentation of second line
{code}
for (Map.Entry<ApplicationTimeoutType, Long> timeout :
app.applicationTimeouts.entrySet()) {
{code}
> Provide an API to update lifetime of an application.
> ----------------------------------------------------
>
> Key: YARN-5611
> URL: https://issues.apache.org/jira/browse/YARN-5611
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: oct16-hard
> Attachments: 0001-YARN-5611.patch, 0002-YARN-5611.patch,
> 0003-YARN-5611.patch, YARN-5611.0004.patch, YARN-5611.0005.patch,
> YARN-5611.v0.patch
>
>
> YARN-4205 monitors an Lifetime of an applications is monitored if required.
> Add an client api to update lifetime of an application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
