[
https://issues.apache.org/jira/browse/YARN-5611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15623498#comment-15623498
]
Jian He commented on YARN-5611:
-------------------------------
- What is the reason to involve RMAppImpl state-machine to update the
application timeout ? I think it's simpler to update directly, not go through
the RMAppImpl state machine..
- This code
{code}
Map<ApplicationTimeoutType, Long> newApplicationExpireTime =
new HashMap<ApplicationTimeoutType, Long>();
newApplicationExpireTime.putAll(newParsedTimeouts);
{code}
can be changed to
{code}
Map<ApplicationTimeoutType, Long> newApplicationExpireTime =
new HashMap<ApplicationTimeoutType, Long>(newParsedTimeouts);
{code}
- I wonder whether we need a separate wrapper class "AppUpdateAttributes" for
the timeout, is it fine to just put application timeout in the
ApplicationStateData class?
> Provide an API to update lifetime of an application.
> ----------------------------------------------------
>
> Key: YARN-5611
> URL: https://issues.apache.org/jira/browse/YARN-5611
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Rohith Sharma K S
> Assignee: Rohith Sharma K S
> Labels: oct16-hard
> Attachments: 0001-YARN-5611.patch, 0002-YARN-5611.patch,
> 0003-YARN-5611.patch, YARN-5611.0004.patch, YARN-5611.v0.patch
>
>
> YARN-4205 monitors an Lifetime of an applications is monitored if required.
> Add an client api to update lifetime of an application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
